-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send bus notifications if first leg is bus #264
base: dev
Are you sure you want to change the base?
Conversation
@binh-dam-ibigroup the test that is failing also fails under dev. I think it is a time/locale issue. I bet it will work when I re-run it tomorrow morning! Failed test has this comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add a test case for an itinerary which first leg is a bus leg. I am seeing a side effect where, when you start tracking with coordinates near the bus stop, it thinks you are already on the bus.
* Given the traveler's position and leg type, check if bus notification should be sent. | ||
*/ | ||
public static boolean shouldNotifyBusOperator(TravelerPosition travelerPosition, boolean isStartOfTrip) { | ||
return (isStartOfTrip) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract a variable for the leg to pass to isBusLeg
and isWithinOperationalNotifyWindow
depending on isStartOfTrip
, and remove line 180.
@@ -136,10 +136,7 @@ public static TripInstruction alignTravelerToTrip( | |||
Locale locale = travelerPosition.locale; | |||
|
|||
if (isApproachingEndOfLeg(travelerPosition)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is at the start of a trip where the first leg is transit, there is no approaching the end of the leg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@binh-dam-ibigroup If possible can you provide a trip which starts with a transit leg? I'm going to edit an existing trip (walk-to-bus-transition.json) to test with, but would prefer a real-world exampl
Checklist
dev
before they can be merged tomaster
)Description
If the trip starts with a bus leg notify bus op.